The API is breaking by your changes, that's why the tests are failing. We need to find out a way to keep the API intact while using DynamicOneDimensionalArray.

I think we need only two data members, items and dtype.
ArrayStack.__new__ will change to,

class ArrayStack(...):
    def __new__(cls, items=None, dtype=int):
        ...

Or in fact,

class ArrayStack(...):
    def __new__(cls, dtype=int):
        ...

items are not needed in parameters.

items = DynamicOneDimensionalArray(dtype, size)

Agreed. In fact, it should be DyamicOneDimensionalArray(dtype, 0).

Currently the size doesn't defaults to 0, so you have to give 0 as the second argument.

>>> from pydatastructs import DynamicOneDimensionalArray as DODA
>>> arr = DODA(int)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/czgdp1807/codezonediitj/pydatastructs/pydatastructs/linear_data_structures/arrays.py", line 207, in __new__
    obj = super().__new__(cls, dtype, *args, **kwargs)
  File "/home/czgdp1807/codezonediitj/pydatastructs/pydatastructs/linear_data_structures/arrays.py", line 70, in __new__
    raise ValueError("1D array cannot be created due to incorrect"
ValueError: 1D array cannot be created due to incorrect information.

We can change the behaviour after some discussion but in a different PR.

We can change the behaviour after some discussion but in a different PR.

As said above you can do that, but in a different PR(from a different branch).

Thanks for the contributions first of all. It's a great experience to work with you. Hoping that you will keep communicating and contributing in this way in future too. :-)

Please update the documentation as well for the new API. The tests failing due to that.
Please see if Stack is used in other modules, update the usage there as well. As far as I remember, BinaryTreeTraversal uses Stack so update is needed there too.

Yes, the comments in the code. I have made some edits in my previous comments which should be visible if you open github.

Please make sure that your code passes the recently added code quality tests. See the logs here. There are few trailing white spaces in your code.

To test your code quality locally, update the master branch by pulling the latest changes and merge into doda branch of this PR.

Codecov Report

Merging #69 into master will decrease coverage by 0.498%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           master       #69       +/-   ##
============================================
- Coverage   98.17%   97.671%   -0.499%     
============================================
  Files          19        23        +4     
  Lines        1257      1503      +246     
============================================
+ Hits         1234      1468      +234     
- Misses         23        35       +12

Thanks. Merging.

If you want you can add your name to https://github.com/codezonediitj/pydatastructs/blob/master/AUTHORS by making a separate PR.